Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix metrics error for --num-scheduler-steps > 1 #8234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BugFix] Fix metrics error for --num-scheduler-steps > 1 #8234

wants to merge 1 commit into from

Conversation

yuleil
Copy link

@yuleil yuleil commented Sep 6, 2024

Fix #8233

Before the fix:
image

After the fix:
image

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@yuleil yuleil marked this pull request as draft September 6, 2024 10:41
@yuleil yuleil marked this pull request as ready for review September 6, 2024 10:48
comaniac
comaniac approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @SolitaryThinker

SolitaryThinker
SolitaryThinker approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@SolitaryThinker SolitaryThinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thank you!

@SolitaryThinker
Copy link
Contributor

/ready

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 6, 2024
@comaniac comaniac enabled auto-merge (squash) September 6, 2024 18:30
@yuleil yuleil marked this pull request as draft September 9, 2024 10:34
auto-merge was automatically disabled September 9, 2024 10:34

Pull request was converted to draft

@yuleil yuleil marked this pull request as ready for review September 9, 2024 14:43
@yuleil yuleil force-pushed the fix-metrics branch 3 times, most recently from 8b94851 to 3ec84ab Compare September 10, 2024 13:46
@Syst3m1cAn0maly
Copy link

Syst3m1cAn0maly commented Sep 26, 2024 •
edited
Loading

Hi !
Is there still some work to be done to complete the PR ?
The problem is still present on v0.6.2 as it is not yet merged.
The auto-merge seems disabled.

Thanks in advance

@comaniac
Copy link
Collaborator

We can merge once the CI is passed (or force merge if the failed tests are flaky)

@njhill
Copy link
Member

njhill commented Sep 28, 2024

@yuleil could you merge in main one more time? tests should be fixed now...

@njhill njhill mentioned this pull request Sep 28, 2024
Open
1 task
@ashgold
Copy link

ashgold commented Sep 28, 2024

Can you check if TPOT has also been resolved by this change?

@njhill
Copy link
Member

njhill commented Sep 30, 2024

cc @robertgshaw2-neuralmagic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comaniac comaniac comaniac approved these changes

@SolitaryThinker SolitaryThinker SolitaryThinker approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123 zhuohan123 is a code owner

@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

@alexm-neuralmagic alexm-neuralmagic Awaiting requested review from alexm-neuralmagic alexm-neuralmagic is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Metrics error for --num-scheduler-steps > 1
6 participants
@yuleil @SolitaryThinker @Syst3m1cAn0maly @comaniac @njhill @ashgold